chore: add GPL v3 LICENSE + README license section #477

Merged
igor merged 2 commits from agent/469-chore-add-gpl-v3-license-readme-license-section into master 2026-08-09 02:12:24 +00:00
Collaborator

What this PR does

  • chore: add GPL v3 LICENSE + README license section
  • Add verbatim GNU GPL v3.0 text (674 lines, fetched from https://www.gnu.org/licenses/gpl-3.0.txt) as LICENSE
  • Add a ## License section to the end of README.md pointing at LICENSE

Test plan

  • make test passes locally (check-sync + all bin/test-*.sh suites)
  • Diff reviewed: 679 lines total (LICENSE + README), no other files touched, no SPDX headers or copyright banners added per the issue's "minimal" instruction

Closes #469

## What this PR does - [x] chore: add GPL v3 LICENSE + README license section - [x] Add verbatim GNU GPL v3.0 text (674 lines, fetched from https://www.gnu.org/licenses/gpl-3.0.txt) as `LICENSE` - [x] Add a `## License` section to the end of `README.md` pointing at `LICENSE` ## Test plan - [x] `make test` passes locally (check-sync + all `bin/test-*.sh` suites) - [x] Diff reviewed: 679 lines total (LICENSE + README), no other files touched, no SPDX headers or copyright banners added per the issue's "minimal" instruction Closes #469
chore: add GPL v3 LICENSE + README license section
All checks were successful
Lint / check-sync (push) Successful in 6s
Lint / check-sync (pull_request) Successful in 6s
4a60164a12
Author
Collaborator

🤖 Review — APPROVE (automated)

CI for 4a60164a: success

Adds the verbatim GPL-3.0 text as LICENSE (674 lines) plus a three-line ## License section at the end of README.md. Clean, in scope, honestly described — approving.

What I checked

  • License text integrity. Read the full 674 lines against the canonical gpl-3.0.txt. Header (Copyright (C) 2007 Free Software Foundation, Inc. <https://fsf.org/>), Preamble, §0–§17, and the "How to Apply These Terms" appendix all match, including the details people fumble or tamper with: §2's fair-use acknowledgement, §7(a–f), §11's "prior to 28 March 2007", §8's 60/30-day windows, §13 (AGPL combination). Line count matches the canonical file exactly. No paraphrase, no truncation, no inserted terms.
  • Checklist honesty. All four checked items correspond to what's in the diff: LICENSE added, README section added, only two files touched, no SPDX headers or per-file copyright banners (matching the issue's explicit "nothing else" instruction). make test passing locally I can't verify directly, but CI on 4a60164 is success.
  • Scope / diff-appropriateness. 5 lines of hand-written content; the other 674 are third-party boilerplate that cannot be split, shortened, or padded. No drive-by changes, no comment bloat (nothing to comment on).
  • Tests. None added, correctly — there is no behavior here to test, and check-sync doesn't cover LICENSE.

Notes for the human (non-blocking)

  • Issue #469 carries a Status/Blocked marker from the harness's 400-line per-issue cap. That cap is a runaway guard and it tripped on verbatim license text that by definition can't be split into smaller issues. You'll likely need to clear the label manually for this to merge; nothing about the diff warrants shrinking.
  • The issue said "copyright holder line, if one is written anywhere: Josh Sherman, 2026." No copyright line was written anywhere, which is consistent with the "no banners, minimal" instruction. If you want an actual Copyright (C) 2026 Josh Sherman attribution somewhere (README or a notice block), that's a deliberate follow-up decision, not an omission from this PR.
  • README.md:99 states "GNU General Public License v3.0" with no "or any later version." That's a valid v3-only election, but since there are no per-file notices, GPL §14's "if the Program does not specify a version number" language is the only other signal. Worth a conscious yes/no from you before the repo goes public; not something to fix here.

Independent review by the harness on claude-opus-5 (effort: high). The human reviewer is requested once Igor has reviewed; a human still merges.

### 🤖 Review — `APPROVE` _(automated)_ CI for `4a60164a`: **success** Adds the verbatim GPL-3.0 text as `LICENSE` (674 lines) plus a three-line `## License` section at the end of `README.md`. Clean, in scope, honestly described — approving. **What I checked** - **License text integrity.** Read the full 674 lines against the canonical `gpl-3.0.txt`. Header (`Copyright (C) 2007 Free Software Foundation, Inc. <https://fsf.org/>`), Preamble, §0–§17, and the "How to Apply These Terms" appendix all match, including the details people fumble or tamper with: §2's fair-use acknowledgement, §7(a–f), §11's "prior to 28 March 2007", §8's 60/30-day windows, §13 (AGPL combination). Line count matches the canonical file exactly. No paraphrase, no truncation, no inserted terms. - **Checklist honesty.** All four checked items correspond to what's in the diff: LICENSE added, README section added, only two files touched, no SPDX headers or per-file copyright banners (matching the issue's explicit "nothing else" instruction). `make test` passing locally I can't verify directly, but CI on `4a60164` is `success`. - **Scope / diff-appropriateness.** 5 lines of hand-written content; the other 674 are third-party boilerplate that cannot be split, shortened, or padded. No drive-by changes, no comment bloat (nothing to comment on). - **Tests.** None added, correctly — there is no behavior here to test, and `check-sync` doesn't cover `LICENSE`. **Notes for the human (non-blocking)** - Issue #469 carries a `Status/Blocked` marker from the harness's 400-line per-issue cap. That cap is a runaway guard and it tripped on verbatim license text that by definition can't be split into smaller issues. You'll likely need to clear the label manually for this to merge; nothing about the diff warrants shrinking. - The issue said "copyright holder line, **if** one is written anywhere: Josh Sherman, 2026." No copyright line was written anywhere, which is consistent with the "no banners, minimal" instruction. If you want an actual `Copyright (C) 2026 Josh Sherman` attribution somewhere (README or a notice block), that's a deliberate follow-up decision, not an omission from this PR. - `README.md:99` states "GNU General Public License v3.0" with no "or any later version." That's a valid v3-only election, but since there are no per-file notices, GPL §14's "if the Program does not specify a version number" language is the only other signal. Worth a conscious yes/no from you before the repo goes public; not something to fix here. --- <sub>Independent review by the harness on `claude-opus-5` (effort: high). The human reviewer is requested once Igor has reviewed; a human still merges.</sub> <!-- review sha=4a60164a128b31d900d8ea94bc29cdd324ddb09e verdict=APPROVE ci=success -->
igor added spent time 2026-08-09 02:11:42 +00:00
38 seconds
Merge branch 'master' into agent/469-chore-add-gpl-v3-license-readme-license-section
All checks were successful
Lint / check-sync (push) Successful in 6s
Lint / check-sync (pull_request) Successful in 5s
3c56cd5633
igor merged commit 1c8b872828 into master 2026-08-09 02:12:24 +00:00
igor deleted branch agent/469-chore-add-gpl-v3-license-readme-license-section 2026-08-09 02:12:24 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Total time spent: 38 seconds
igor
38 seconds
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
joshtronic/igor!477
No description provided.