docs: sync review directive comment/scope dimensions from distillery proof-2 #484

Merged
igor merged 2 commits from agent/482-docs-sync-review-directive-dimensions-from into master 2026-08-09 06:00:40 +00:00
Collaborator

What this PR does

  • docs: sync review directive comment/scope dimensions from distillery proof-2
  • Replace the "Comment bloat" bullet in bin/lib/review-directive.md with five bullets: comment contract, minimal touch, contract conformance, verification honesty, and least privilege

Test plan

  • make test passes
  • make lint passes
  • git diff shows exactly one hunk in exactly one file

Closes #482

## What this PR does - [x] docs: sync review directive comment/scope dimensions from distillery proof-2 - [x] Replace the "Comment bloat" bullet in `bin/lib/review-directive.md` with five bullets: comment contract, minimal touch, contract conformance, verification honesty, and least privilege ## Test plan - [x] `make test` passes - [x] `make lint` passes - [x] `git diff` shows exactly one hunk in exactly one file Closes #482
docs: sync review directive comment/scope dimensions from distillery proof-2
All checks were successful
Lint / check-sync (pull_request) Successful in 6s
Lint / check-sync (push) Successful in 5s
f64ffda566
Author
Collaborator

🤖 Review — APPROVE (automated)

CI for f64ffda5: success

Prose-only sync of bin/lib/review-directive.md: the single "Comment bloat" bullet is replaced by five bullets (comment contract, minimal touch, contract conformance, verification honesty, least privilege). Approving — it matches the spec exactly.

  • Text conformance: I diffed the added block against the issue's specified replacement line-by-line, including wrapping and punctuation (--, *why*, *what*, quoted examples). It is character-identical across all five bullets.
  • Boundaries: the removal starts at - **Comment bloat.** Comments earn their place only and ends at -- don't wave it through as a style nit., exactly as specified. Nothing before (Diff-appropriateness) or after (Honest checklist) is touched.
  • Scope: one hunk, one file, no code, no CI config, no drive-by edits. Meets the "one-hunk prose sync" constraint.
  • Internal consistency: the new "Contract conformance" bullet's back-reference to "the comment contract above" resolves correctly against the renamed bullet in the same list.
  • CI: success on the head commit; checklist items (make test, make lint, single-hunk) are consistent with what the diff shows.

No test coverage note — this is a prompt surface with no test hook in the diff; CI green is the available signal. Worth remembering the issue's own framing: merging this deploys the new reviewer directive on the next tick, so it's live prose rather than dormant docs.


Independent review by the harness on claude-opus-5 (effort: high). The human reviewer is requested once Igor has reviewed; a human still merges.

### 🤖 Review — `APPROVE` _(automated)_ CI for `f64ffda5`: **success** Prose-only sync of `bin/lib/review-directive.md`: the single "Comment bloat" bullet is replaced by five bullets (comment contract, minimal touch, contract conformance, verification honesty, least privilege). Approving — it matches the spec exactly. - **Text conformance:** I diffed the added block against the issue's specified replacement line-by-line, including wrapping and punctuation (`--`, `*why*`, `*what*`, quoted examples). It is character-identical across all five bullets. - **Boundaries:** the removal starts at `- **Comment bloat.** Comments earn their place only` and ends at `-- don't wave it through as a style nit.`, exactly as specified. Nothing before (`Diff-appropriateness`) or after (`Honest checklist`) is touched. - **Scope:** one hunk, one file, no code, no CI config, no drive-by edits. Meets the "one-hunk prose sync" constraint. - **Internal consistency:** the new "Contract conformance" bullet's back-reference to "the comment contract above" resolves correctly against the renamed bullet in the same list. - **CI:** `success` on the head commit; checklist items (`make test`, `make lint`, single-hunk) are consistent with what the diff shows. No test coverage note — this is a prompt surface with no test hook in the diff; CI green is the available signal. Worth remembering the issue's own framing: merging this deploys the new reviewer directive on the next tick, so it's live prose rather than dormant docs. --- <sub>Independent review by the harness on `claude-opus-5` (effort: high). The human reviewer is requested once Igor has reviewed; a human still merges.</sub> <!-- review sha=f64ffda566755004f8b038f25bfa376a7b11f28c verdict=APPROVE ci=success -->
igor added spent time 2026-08-09 05:16:49 +00:00
19 seconds
Merge branch 'master' into agent/482-docs-sync-review-directive-dimensions-from
All checks were successful
Lint / check-sync (push) Successful in 6s
Lint / check-sync (pull_request) Successful in 6s
f56eb363bd
igor merged commit 39f59fd3a9 into master 2026-08-09 06:00:40 +00:00
igor deleted branch agent/482-docs-sync-review-directive-dimensions-from 2026-08-09 06:00:40 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Total time spent: 19 seconds
igor
19 seconds
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
joshtronic/igor!484
No description provided.