chore: feat(validation): accept a deploy-verifiable static site as a test signal #390

Merged

joshtronic merged 1 commit from agent/385-validation-accept-a-static-site-s-build-deploy into master

2026-07-15 15:28:34 +00:00

igor commented

2026-07-15 15:16:27 +00:00

Collaborator

What this PR does

feat(validation): accept a deploy-verifiable static site as a test signal
Add check_deploy_smoke_signal to lib/repo-checks.sh: passes when a repo's agent.json declares a live .smoke.url (the same file lib/automerge.sh reads for auto-merge eligibility) AND the build stamps a deploy-sha marker into the page
Wire it as an alternate path inside check_test_signal, alongside the existing unit-test detectors -- a static site with no unit suite (e.g. snail.io) can now satisfy validation via its deploy-sha smoke instead
Update the "Test setup detected" checklist hint in validate_repo_local to mention the new path
The check_ci_workflow requirement (CI building on pull_request) is untouched and still runs separately -- this only substitutes for the unit-test gate, not CI

Test plan

bin/test-repo-checks.sh: new cases for check_deploy_smoke_signal (smoke.url + marker passes; missing marker fails; missing agent.json fails; missing .smoke.url fails) plus confirming check_test_signal now passes via this path -- all pass
make test passes (full suite)
make lint -- shellcheck clean on the two changed files (pre-existing unrelated warnings on bin/test-automerge.sh/bin/tick.sh verified present on master before this change too)
No manual verification needed beyond the above; this is a pure local-clone validation check with no live network calls

Closes #385

## What this PR does - [x] feat(validation): accept a deploy-verifiable static site as a test signal - [x] Add `check_deploy_smoke_signal` to `lib/repo-checks.sh`: passes when a repo's `agent.json` declares a live `.smoke.url` (the same file `lib/automerge.sh` reads for auto-merge eligibility) AND the build stamps a `deploy-sha` marker into the page - [x] Wire it as an alternate path inside `check_test_signal`, alongside the existing unit-test detectors -- a static site with no unit suite (e.g. snail.io) can now satisfy validation via its deploy-sha smoke instead - [x] Update the "Test setup detected" checklist hint in `validate_repo_local` to mention the new path - [x] The `check_ci_workflow` requirement (CI building on `pull_request`) is untouched and still runs separately -- this only substitutes for the unit-test gate, not CI ## Test plan - [x] `bin/test-repo-checks.sh`: new cases for `check_deploy_smoke_signal` (smoke.url + marker passes; missing marker fails; missing agent.json fails; missing `.smoke.url` fails) plus confirming `check_test_signal` now passes via this path -- all pass - [x] `make test` passes (full suite) - [x] `make lint` -- shellcheck clean on the two changed files (pre-existing unrelated warnings on `bin/test-automerge.sh`/`bin/tick.sh` verified present on `master` before this change too) - [x] No manual verification needed beyond the above; this is a pure local-clone validation check with no live network calls Closes #385

igor added 1 commit

2026-07-15 15:16:27 +00:00

chore: feat(validation): accept a deploy-verifiable static site as a test signal

Lint / check-sync (push) Successful in 5s

Details

Lint / check-sync (pull_request) Successful in 4s

Details

cd36c404ef

igor commented

2026-07-15 15:18:44 +00:00

Author

Collaborator

🤖 Review — `APPROVE` (automated)

CI for cd36c404: success

Adds check_deploy_smoke_signal as an alternate test-signal path for static sites lacking a unit suite, wired into check_test_signal, with matching test coverage. CI green, in scope (~50 lines), checklist honest.

Verified against the diff:

check_deploy_smoke_signal requires both agent.json .smoke.url (via jq) and a deploy-sha string in the tree — matches the description.
Wiring into check_test_signal is a pure additive && return 0; the Cargo/Go/pytest/npm paths are untouched.
check_ci_workflow is genuinely not in the diff — the "untouched" claim holds.
Test plan matches: 4 new check_deploy_smoke_signal cases (pass, missing marker, missing agent.json, missing .smoke.url) plus two check_test_signal assertions.
Fails closed if jq is absent (2>/dev/null, empty url → return 1).

Non-blocking observations (worth a human glance, not a gate):

The marker check git grep -qiF 'deploy-sha' is deliberately loose: case-insensitive, fixed-string, across the entire tree. Any file mentioning deploy-sha anywhere (a comment, doc, unrelated config) satisfies it. That's an intentionally weak heuristic substituting for a unit suite, consistent with issue #385's intent, but it means the gate is easy to trip accidentally. Fine as a signal detector; flagging so the human knows the bar here is "string exists," not "build actually stamps the page."
The description claims .smoke.url is "the same file lib/automerge.sh reads." I can't verify that from this diff (automerge.sh isn't shown), but the new function is self-contained and its behavior is fully covered by the added tests, so the correctness of this change doesn't depend on that claim.

No defects that block merge.

_{Independent review by the harness on claude-opus-4-8 (effort: high). The human reviewer is requested once Igor has reviewed; a human still merges.}

### 🤖 Review — `APPROVE` _(automated)_ CI for `cd36c404`: **success** Adds `check_deploy_smoke_signal` as an alternate test-signal path for static sites lacking a unit suite, wired into `check_test_signal`, with matching test coverage. CI green, in scope (~50 lines), checklist honest. **Verified against the diff:** - `check_deploy_smoke_signal` requires both `agent.json` `.smoke.url` (via `jq`) and a `deploy-sha` string in the tree — matches the description. - Wiring into `check_test_signal` is a pure additive `&& return 0`; the Cargo/Go/pytest/npm paths are untouched. - `check_ci_workflow` is genuinely not in the diff — the "untouched" claim holds. - Test plan matches: 4 new `check_deploy_smoke_signal` cases (pass, missing marker, missing agent.json, missing `.smoke.url`) plus two `check_test_signal` assertions. - Fails closed if `jq` is absent (`2>/dev/null`, empty url → return 1). **Non-blocking observations (worth a human glance, not a gate):** - The marker check `git grep -qiF 'deploy-sha'` is deliberately loose: case-insensitive, fixed-string, across the *entire* tree. Any file mentioning `deploy-sha` anywhere (a comment, doc, unrelated config) satisfies it. That's an intentionally weak heuristic substituting for a unit suite, consistent with issue #385's intent, but it means the gate is easy to trip accidentally. Fine as a signal detector; flagging so the human knows the bar here is "string exists," not "build actually stamps the page." - The description claims `.smoke.url` is "the same file `lib/automerge.sh` reads." I can't verify that from this diff (automerge.sh isn't shown), but the new function is self-contained and its behavior is fully covered by the added tests, so the correctness of *this* change doesn't depend on that claim. No defects that block merge. --- <sub>Independent review by the harness on `claude-opus-4-8` (effort: high). The human reviewer is requested once Igor has reviewed; a human still merges.</sub>

igor added spent time

2026-07-15 15:18:44 +00:00

40 seconds

igor requested review from joshtronic

2026-07-15 15:18:45 +00:00