chore(seo): drop the deprecated SEO_AGENTIC_SITES env fallback #300

Merged

joshtronic merged 1 commit from chore/drop-seo-agentic-sites into master

2026-06-30 20:39:54 +00:00

igor commented

2026-06-30 17:25:09 +00:00

Collaborator

You removed SEO_AGENTIC_SITES from the host .env, and every agentic repo now carries agent.json .seo (#298 + the per-repo config PRs). So the transitional fallback is dead code. This removes the env-map branch in seo_agentic_repo_for, the export + deprecation comment in tick.sh, and the fallback/precedence test cases. seo_agentic_repo_for now resolves agentic domains from agent.json alone. Net -37 lines; check-sync green.

You removed `SEO_AGENTIC_SITES` from the host `.env`, and every agentic repo now carries `agent.json .seo` (#298 + the per-repo config PRs). So the transitional fallback is dead code. This removes the env-map branch in `seo_agentic_repo_for`, the `export` + deprecation comment in `tick.sh`, and the fallback/precedence test cases. `seo_agentic_repo_for` now resolves agentic domains from `agent.json` alone. Net -37 lines; check-sync green.

igor added 1 commit

2026-06-30 17:25:09 +00:00

chore(seo): drop the deprecated SEO_AGENTIC_SITES env fallback

Lint / check-sync (push) Successful in 5s

Details

Lint / check-sync (pull_request) Successful in 4s

Details

85dc99478b

The agentic-SEO opt-in moved to agent.json `.seo` in #298, and the env entry has
now been removed from the host `.env`. Every agentic repo carries agent.json
`.seo`, so the transitional fallback is dead code -- remove it: the env-map
branch in seo_agentic_repo_for, the export + deprecation comment in tick.sh, and
the fallback/precedence test cases. seo_agentic_repo_for now resolves agentic
domains from agent.json alone. make test green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011KXPafSYJPY6XkWHHk1Lfs

igor commented

2026-06-30 17:35:08 +00:00

Author

Collaborator

🤖 Review — `COMMENT` (automated)

CI for 85dc9947: success

Clean removal of the deprecated SEO_AGENTIC_SITES env fallback from seo_agentic_repo_for, its tick.sh export, and the related tests. The diff itself is self-consistent and well-scoped; my only reservation is an operational precondition I can't verify from the diff.

What's correct

lib/seo-analysis.sh: the env-fallback loop (and its now-unused local entry ed erepo / local IFS='|') is fully removed; the function correctly ends on the done <<<"$repos" agent.json loop followed by return 0. No dangling references in this function.
bin/test-seo-agentic.sh: env-only cases (old #4 "env fallback resolves" and #5 "agent.json wins over env map") are dropped; remaining cases renumbered 1–5 consistently, and the SEO_AGENTIC_SITES='' prefixes are stripped from every invocation. Header comment updated to match.
bin/tick.sh: export and deprecation block removed; replaced comment is accurate. No CI-config files touched, no security surface.
CI is success.

Reservation the human should weigh (why not an outright APPROVE)

The whole purpose of this fallback was a migration safety net that logged once when it fired, with the documented deletion trigger being "once that log goes quiet." The PR asserts every agentic repo now carries agent.json .seo (#298 + per-repo PRs), but that's external state I can't confirm from the diff or CI. If any agentic domain hasn't actually migrated, this change turns a logged fallback into a silent miss (seo_agentic_repo_for returns empty → no SEO ticket filed), and CI won't catch it. Please confirm the deprecation log actually went quiet / no live domain still depends on the env map before merging.
Minor / can't-see-from-diff: worth a quick grep for any leftover SEO_AGENTIC_SITES references outside these three files (e.g. .env.example, docs) so nothing dangles. Not a blocker if there are none.

No defect in the code as written — this is fail-closed on the unverifiable migration precondition, not a rework request.

_{Independent review by the harness on claude-opus-4-8. The human reviewer is requested once Igor has reviewed; a human still merges.}

### 🤖 Review — `COMMENT` _(automated)_ CI for `85dc9947`: **success** Clean removal of the deprecated `SEO_AGENTIC_SITES` env fallback from `seo_agentic_repo_for`, its `tick.sh` export, and the related tests. The diff itself is self-consistent and well-scoped; my only reservation is an operational precondition I can't verify from the diff. **What's correct** - `lib/seo-analysis.sh`: the env-fallback loop (and its now-unused `local entry ed erepo` / `local IFS='|'`) is fully removed; the function correctly ends on the `done <<<"$repos"` agent.json loop followed by `return 0`. No dangling references in this function. - `bin/test-seo-agentic.sh`: env-only cases (old #4 "env fallback resolves" and #5 "agent.json wins over env map") are dropped; remaining cases renumbered 1–5 consistently, and the `SEO_AGENTIC_SITES='' ` prefixes are stripped from every invocation. Header comment updated to match. - `bin/tick.sh`: export and deprecation block removed; replaced comment is accurate. No CI-config files touched, no security surface. - CI is `success`. **Reservation the human should weigh (why not an outright APPROVE)** - The whole purpose of this fallback was a migration safety net that **logged once when it fired**, with the documented deletion trigger being "once that log goes quiet." The PR asserts every agentic repo now carries `agent.json .seo` (#298 + per-repo PRs), but that's external state I can't confirm from the diff or CI. If any agentic domain hasn't actually migrated, this change turns a logged fallback into a **silent miss** (`seo_agentic_repo_for` returns empty → no SEO ticket filed), and CI won't catch it. Please confirm the deprecation log actually went quiet / no live domain still depends on the env map before merging. - Minor / can't-see-from-diff: worth a quick grep for any leftover `SEO_AGENTIC_SITES` references outside these three files (e.g. `.env.example`, docs) so nothing dangles. Not a blocker if there are none. No defect in the code as written — this is fail-closed on the unverifiable migration precondition, not a rework request. --- <sub>Independent review by the harness on `claude-opus-4-8`. The human reviewer is requested once Igor has reviewed; a human still merges.</sub>

igor added spent time

2026-06-30 17:35:08 +00:00

58 seconds

igor requested review from joshtronic

2026-06-30 17:35:09 +00:00