forks/simplexml_debug
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle null-namespace special case (or at least handle it better...)

Browse source
This commit is contained in:
Rowan Collins 2012-09-02 22:05:14 +01:00
parent 853249c284
commit 490e4376a3
1 changed files with 23 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

24
simplexml_dump.php
View file

@ -13,6 +13,10 @@ function simplexml_dump(SimpleXMLElement $sxml, $return=false)
{ {
$indent = "\t"; $indent = "\t";
// Get all the namespaces declared at the *root* of this document
// All the items we're looking at are in the same document, so we only need do this once
$doc_ns = $sxml->getDocNamespaces(false);
$dump = ''; $dump = '';
// Note that the header is added at the end, so we can add stats // Note that the header is added at the end, so we can add stats
$dump .= '[' . PHP_EOL; $dump .= '[' . PHP_EOL;
@ -83,8 +87,6 @@ function simplexml_dump(SimpleXMLElement $sxml, $return=false)
// whether declared in this node, in its ancestors, or in its descendants // whether declared in this node, in its ancestors, or in its descendants
$all_ns = $item->getNamespaces(true); $all_ns = $item->getNamespaces(true);
// If the default namespace is never declared, it will never show up using the below code // If the default namespace is never declared, it will never show up using the below code
// This will still mess up in the case where a parent element is missing the xmlns declaration,
// but a descendant adds it, because SimpleXML will look ahead and fill $all_ns[''] incorrectly
if ( ! array_key_exists('', $all_ns) ) if ( ! array_key_exists('', $all_ns) )
{ {
$all_ns[''] = NULL; $all_ns[''] = NULL;
@ -95,6 +97,24 @@ function simplexml_dump(SimpleXMLElement $sxml, $return=false)
$children = count($item->children($ns_uri)); $children = count($item->children($ns_uri));
$attributes = count($item->attributes($ns_uri)); $attributes = count($item->attributes($ns_uri));
// Somewhat confusingly, in the case where a parent element is missing the xmlns declaration,
// but a descendant adds it, SimpleXML will look ahead and fill $all_ns[''] incorrectly
if (
$ns_alias == ''
&&
! is_null($ns_uri)
&&
$children == 0
&&
$attributes == 0
)
{
// Try looking for a default namespace without a known URI
$ns_uri = NULL;
$children = count($item->children($ns_uri));
$attributes = count($item->attributes($ns_uri));
}
// Don't show zero-counts, as they're not that useful // Don't show zero-counts, as they're not that useful
if ( $children == 0 && $attributes == 0 ) if ( $children == 0 && $attributes == 0 )
{ {