From 490e4376a3d9360f9774e3804b624e9fcd19f5af Mon Sep 17 00:00:00 2001
From: Rowan Collins <git@rwec.co.uk>
Date: Sun, 2 Sep 2012 22:05:14 +0100
Subject: [PATCH] Handle null-namespace special case (or at least handle it
 better...)

---
 simplexml_dump.php | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/simplexml_dump.php b/simplexml_dump.php
index 4403d47..8099e52 100644
--- a/simplexml_dump.php
+++ b/simplexml_dump.php
@@ -13,6 +13,10 @@ function simplexml_dump(SimpleXMLElement $sxml, $return=false)
 {
 	$indent = "\t";
 
+	// Get all the namespaces declared at the *root* of this document
+	// All the items we're looking at are in the same document, so we only need do this once
+	$doc_ns = $sxml->getDocNamespaces(false);
+	
 	$dump = '';
 	// Note that the header is added at the end, so we can add stats
 	$dump .= '[' . PHP_EOL;
@@ -83,17 +87,33 @@ function simplexml_dump(SimpleXMLElement $sxml, $return=false)
 			// 	whether declared in this node, in its ancestors, or in its descendants
 			$all_ns = $item->getNamespaces(true);
 			// If the default namespace is never declared, it will never show up using the below code
-			// This will still mess up in the case where a parent element is missing the xmlns declaration,
-			//	but a descendant adds it, because SimpleXML will look ahead and fill $all_ns[''] incorrectly
 			if ( ! array_key_exists('', $all_ns) )
 			{
 				$all_ns[''] = NULL;
 			}
-
+			
 			foreach ( $all_ns as $ns_alias => $ns_uri )
 			{
 				$children = count($item->children($ns_uri));
 				$attributes = count($item->attributes($ns_uri));
+				
+				// Somewhat confusingly, in the case where a parent element is missing the xmlns declaration,
+				//	but a descendant adds it, SimpleXML will look ahead and fill $all_ns[''] incorrectly
+				if ( 
+					$ns_alias == ''
+					&&
+					! is_null($ns_uri)
+					&&
+					$children == 0
+					&&
+					$attributes == 0
+				)
+				{
+					// Try looking for a default namespace without a known URI
+					$ns_uri = NULL;
+					$children = count($item->children($ns_uri));
+					$attributes = count($item->attributes($ns_uri));
+				}
 
 				// Don't show zero-counts, as they're not that useful
 				if ( $children == 0 && $attributes == 0 )