Coverage testing wasn't analyzing files that weren't touched at all. All files
are now included with the exception of the Database files that I'll be
consolidating soon into a single class (no reason to have so many classes
touched just to create a single database object). Aside from that, all classes
are now represented in the coverage report, Sad to go from 80% down to 50% but
oh well, it's for the best!
Finished up all the low hanging fruit (working the classes I already started
that were just shy of 100% coverage). Just shy of 80% coverage at this point.
Trying to figure out where I should be echoing the zend_extension line. On my
local system I slapped it to the bottom of the xdebug conf.d file. Unsure if
that directory and/or file even exist.
Seemed easier than trying to figure out how to force the prompt to accept the
unknown IP (perhaps not possible at all as it is part of SSH?). `yes` didn't
work, unfortunately.
Seems the PECL version of test-helpers isn't up to date. Had to compile it
manually locally and evidently have to do the same on travis-ci until pecl is
updated.
Also fixed a few minor bugs and reworked Browser class to not use the constant
UNIT_TESTING so I could get the class to 100% coverage. Adds a dependency of
testing_helpers which I believe is available on Travis CI by default. Up to 75%
coverage, w00t w00t!
Also found a bug in the Form class that would bork phone numbers with dashes in
them. Even though the Form class is going to go away eventually I wanted to fix
the issue.
The class didn't provide any value and promised that it would in the future.
Any sort of redundant connection logic should simply be contained in a class
that can be extended and not an API-centric common class. Trying to move away
from all common classes in favor of classes that can be reused in different
parts of the core as well as outside of it.
