joshtronic/pickles
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

Cleaned up old code and wrote more tests

Browse source 
Log class is fully tested, Dynamic class is nearly complete but I wanted to see what Travis would bark about regarding LESS and SASS
This commit is contained in:
Joshua Sherman 2014-01-02 18:16:15 -05:00
parent 3fee938c2a
commit bfa35794b5
4 changed files with 191 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

16
classes/Dynamic.php
View file

@ -150,17 +150,7 @@ class Dynamic extends Object
{
$reference = $original_reference;
/**
* Disabled the sanity checks because I'm using LESS's @import for
* some hackery and it's not validating as true due to the imported
* file not being interrogated. Should be okay as minifying is now
* a subjective action that's turned on in the config due to the
* issues I had in production with it.
*
* if (is_writable($path)
* && (!file_exists($minified_filename) || filemtime($original_filename) > filemtime($minified_filename))
* && $this->config->pickles['minify'] === true)
*/
// @todo LESS and SASS compiling should happen regardless of minification
if ($this->config->pickles['minify'] === true)
{
// Compiles LESS & SASS to CSS before minifying
@ -203,10 +193,6 @@ class Dynamic extends Object
{
$reference = $minified_reference;
}
else
{
Log::warning('Unable to minify ' . $original_reference . ' and a minified copy does not already exist');
}
$reference = $this->reference($reference);
}