joshtronic/pickles
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

Added role based default methods

Browse source 
One of @geoffoliver's suggestions, default methods that are exclusive to the user's permission level. Named __default_ROLE(). No more conditionals in the code since you can now isolate the logic
This commit is contained in:
Josh Sherman 2012-10-14 18:46:29 -04:00
parent 8fb7622061
commit b31746b1c2
3 changed files with 42 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

21
classes/Controller.php
View file

@ -289,8 +289,21 @@ class Controller extends Object
// Gets the profiler status
$profiler = $this->config->pickles['profiler'];
$default_method = '__default';
$role_method = null;
if (isset($_SESSION['__pickles']['security']['role']) && !String::isEmpty($_SESSION['__pickles']['security']['role']))
{
$role_method = '__default_' . $_SESSION['__pickles']['security']['role'];
if (method_exists($module, $role_method))
{
$default_method = $role_method;
}
}
// Attempts to execute the default method
if (method_exists($module, '__default'))
if ($default_method == $role_method || method_exists($module, $default_method))
{
if (isset($requested_id))
{
@ -300,7 +313,7 @@ class Controller extends Object
// Starts a timer before the module is executed
if ($profiler === true || stripos($profiler, 'timers') !== false)
{
Profiler::timer('module __default');
Profiler::timer('module ' . $default_method);
}
$valid_request = false;
@ -370,7 +383,7 @@ class Controller extends Object
*/
if ($valid_request && $valid_security_hash)
{
$module_return = $module->__default();
$module_return = $module->$default_method();
if ($module_return === null)
{
@ -385,7 +398,7 @@ class Controller extends Object
// Stops the module timer
if ($profiler === true || stripos($profiler, 'timers') !== false)
{
Profiler::timer('module __default');
Profiler::timer('module ' . $default_method);
}
// Sets meta data from the module