joshtronic/pickles
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

Added ability to pass in an array of integers assumed to be ID's

Browse source 
Previously new Model(array(1, 2, 3)); would results in a query like SELECT * FROM table WHERE 1 AND 2 AND 3; which would typically result in an out of memory error depending on the number of rows in the table (as all would be returned). Added detection for an array of integers and forces that to be considered new Model(array('id' => array(1, 2, 3))). As I type this I think I need to go back and make an additional change.
This commit is contained in:
Josh Sherman 2012-11-06 09:03:03 -05:00
parent 8da54b14ea
commit b2037343d9
2 changed files with 30 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
classes/Model.php
View file

@ -617,6 +617,21 @@ class Model extends Object
// Adds the WHERE conditionals
if ($this->conditions != false)
{
$use_id = true;
foreach ($this->conditions as $column => $value)
{
if (is_string($column) || is_string($value))
{
$use_id = false;
}
}
if ($use_id)
{
$this->conditions = array($this->columns['id'] => $this->conditions);
}
$this->sql[] = 'WHERE ' . (is_array($this->conditions) ? $this->generateConditions($this->conditions) : $this->conditions);
}