joshtronic/pickles
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

Fixed Cache::delete() when passing an array of keys

Browse source 
Since get() allows you to pass an array and get all of the keys back, I assumed delete worked the same way. It does not.
This commit is contained in:
Josh Sherman 2012-11-07 19:28:44 -05:00
parent a0ad85e8e9
commit a36d51bb1a
2 changed files with 32 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

21
classes/Cache.php
View file

@ -148,7 +148,7 @@ class Cache extends Object
/** /**
* Get Key * Get Key
* *
* Gets the value of the key and returns it. * Gets the value of the key(s) and returns it.
* *
* @param mixed $keys key(s) to retrieve * @param mixed $keys key(s) to retrieve
* @return mixed value(s) of the requested key(s), false if not set * @return mixed value(s) of the requested key(s), false if not set
@ -204,16 +204,27 @@ class Cache extends Object
/** /**
* Delete Key * Delete Key
* *
* Deletes the specified key. * Deletes the specified key(s).
* *
* @param string $key key to delete * @param mixed $keys key(s) to delete
* @return boolean status of deleting the key * @return boolean status of deleting the key
*/ */
public function delete($key) public function delete($keys)
{ {
if ($this->open()) if ($this->open())
{ {
return $this->connection->delete(strtoupper($this->namespace . $key)); if (!is_array($keys))
{
$keys = array($keys);
}
// Memcache() doesn't let you pass an array to delete all records the same way you can with get()
foreach ($keys as $key)
{
$this->connection->delete(strtoupper($this->namespace . $key));
}
return true;
} }
return false; return false;

21
jar.php
View file

@ -620,7 +620,7 @@ class Cache extends Object
/** /**
* Get Key * Get Key
* *
* Gets the value of the key and returns it. * Gets the value of the key(s) and returns it.
* *
* @param mixed $keys key(s) to retrieve * @param mixed $keys key(s) to retrieve
* @return mixed value(s) of the requested key(s), false if not set * @return mixed value(s) of the requested key(s), false if not set
@ -676,16 +676,27 @@ class Cache extends Object
/** /**
* Delete Key * Delete Key
* *
* Deletes the specified key. * Deletes the specified key(s).
* *
* @param string $key key to delete * @param mixed $keys key(s) to delete
* @return boolean status of deleting the key * @return boolean status of deleting the key
*/ */
public function delete($key) public function delete($keys)
{ {
if ($this->open()) if ($this->open())
{ {
return $this->connection->delete(strtoupper($this->namespace . $key)); if (!is_array($keys))
{
$keys = array($keys);
}
// Memcache() doesn't let you pass an array to delete all records the same way you can with get()
foreach ($keys as $key)
{
$this->connection->delete(strtoupper($this->namespace . $key));
}
return true;
} }
return false; return false;