joshtronic/php-loremipsum
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: ensure passed tags are strings

Browse source 
Newer versions of PHP raise a warning if you attempt to use array syntax
against non-strings / non-arrays. Added sanity check to ensure we're
working with a string, otherwise skip it.

Also added in PHP 8.1 to the testing suite and bumped the copyright.

Bumped version to 2.0 since as the change in expected output is a
breaking change.
This commit is contained in:
Josh Sherman 2022-01-04 21:06:55 -06:00
parent ae53465dad
commit c9e2957c23
5 changed files with 23 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/LoremIpsumTest.php
View file

@ -183,5 +183,16 @@ class LoremIpsumTest extends TestCase
$this->$assertRegExp('/^<li>[a-z]+<\/li>$/i', $word);
}
}
/**
* @depends testAssertRegExp
*/
public function testSkipNonStringTag($assertRegExp)
{
$lipsum = new LoremIpsum();
$this->$assertRegExp('/^[a-z]+$/i', $lipsum->word(123));
$this->$assertRegExp('/^[a-z]+$/i', $lipsum->word(array(1, 2, 3)));
$this->$assertRegExp('/^[a-z]+$/i', $lipsum->word(true));
}
}