joshtronic/php-googleplaces
1
0
Fork 0
Code Issues 2 Pull requests 3 Projects Releases Packages Wiki Activity Actions

Divide and conquer #7

Merged
jonathanstanley merged 2 commits from master into master 2014-03-12 15:36:12 +00:00
Conversation 6 Commits 2 Files changed 1 +59 -1
jonathanstanley commented 2014-03-11 22:23:51 +00:00 (Migrated from github.com)
Copy link

This isn't polished at all, but most of the heavy lifting is done.

I think this gets us 90% towards the goal of issue https://github.com/joshtronic/php-googleplaces/issues/5

This isn't polished at all, but most of the heavy lifting is done. I think this gets us 90% towards the goal of issue https://github.com/joshtronic/php-googleplaces/issues/5
🎉 1
joshtronic commented 2014-03-12 15:36:06 +00:00 (Migrated from github.com)
Copy link

Very nice!!

Very nice!!
Surt commented 2015-11-03 18:01:42 +00:00 (Migrated from github.com)
Copy link

Hi, any news about this feature? is it possible to use it? seems like a great addition and I'm actually in need of it.

EDITED: actually I saw it, it's done automatically when subradius is defined. In any case google responds with an INVALID_REQUEST response.

Hi, any news about this feature? is it possible to use it? seems like a great addition and I'm actually in need of it. EDITED: actually I saw it, it's done automatically when `subradius` is defined. In any case google responds with an `INVALID_REQUEST` response.
joshtronic commented 2015-11-03 19:14:50 +00:00 (Migrated from github.com)
Copy link

ACK That's no good @Surt ... feel free to debug and resolve if you have a moment. I'll try to make some time this week to see what may be happening. @bristweb feel free to check into it if you have time as well.

Thanks!

ACK That's no good @Surt ... feel free to debug and resolve if you have a moment. I'll try to make some time this week to see what may be happening. @bristweb feel free to check into it if you have time as well. Thanks!
jonathanstanley commented 2015-11-03 19:20:43 +00:00 (Migrated from github.com)
Copy link

Hmm I took a look at some comments I left here:
https://github.com/joshtronic/php-googleplaces/issues/5#issuecomment-37577261

It looks like you need to set the radius and subradius to an integer. ex:
$radius = 40000; $subradius = 20000;

The script shouldn't alter the request other than simply creating a bunch of smaller requests. Does the request work if you do not set the subradius?

Other than that... it's been a little while since I've looked at this....

Hmm I took a look at some comments I left here: https://github.com/joshtronic/php-googleplaces/issues/5#issuecomment-37577261 It looks like you need to set the radius and subradius to an integer. ex: `$radius = 40000; $subradius = 20000;` The script shouldn't alter the request other than simply creating a bunch of smaller requests. Does the request work if you do not set the subradius? Other than that... it's been a little while since I've looked at this....
Surt commented 2015-11-03 20:27:07 +00:00 (Migrated from github.com)
Copy link

It works like a charm. It was my fault due to the use of $google_places->rankby = 'distance';
didn't have the time to check it deeper but getting rid of it it works right.

Thanks a lot for your work

It works like a charm. It was my fault due to the use of `$google_places->rankby = 'distance';` didn't have the time to check it deeper but getting rid of it it works right. Thanks a lot for your work
joshtronic commented 2015-11-03 22:09:23 +00:00 (Migrated from github.com)
Copy link

@Surt glad it worked out! Should probably add something in there to raise an exception or ignore the flag if it's there. Appreciate you bringing this to my attention!

@Surt glad it worked out! Should probably add something in there to raise an exception or ignore the flag if it's there. Appreciate you bringing this to my attention!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: joshtronic/php-googleplaces#7
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?