fix: dossier_get must trim extracted values (validator accepts what the reader returns padded) #475

New issue

Closed

opened 2026-08-09 02:05:04 +00:00 by igor · 0 comments

igor commented

2026-08-09 02:05:04 +00:00

Collaborator

One-line fix + one test. In lib/dossier.sh, dossier_get echoes the raw value after stripping at most ONE leading space (value="${value# }"), while _dossier_validate_metadata trims before comparing. Consequence, reproduced on master:

# Metadata block line:  type:  arcade␠␠   (two leading, two trailing spaces)
dossier_validate  -> PASS (post-#468 trim-before-compare accepts it)
dossier_get type  -> " arcade  "   (untrimmed -- breaks [ "$(dossier_get . type)" = "arcade" ] and padded urls reach curl)

The change: in dossier_get, trim the extracted value (leading AND trailing whitespace) with the existing _dossier_trim helper before the empty-check and echo. Apply the same to the agent.json fallback values for symmetry (jq output is clean today, but the contract should be uniform).

The test: extend bin/test-dossier.sh with a padded fixture (type: arcade ) asserting three-way agreement: dossier_validate passes, dossier_keys lists type, and dossier_get returns exactly arcade.

Nothing else in scope.

One-line fix + one test. In `lib/dossier.sh`, `dossier_get` echoes the raw value after stripping at most ONE leading space (`value="${value# }"`), while `_dossier_validate_metadata` trims before comparing. Consequence, reproduced on master: ``` # Metadata block line: type: arcade␠␠ (two leading, two trailing spaces) dossier_validate -> PASS (post-#468 trim-before-compare accepts it) dossier_get type -> " arcade " (untrimmed -- breaks [ "$(dossier_get . type)" = "arcade" ] and padded urls reach curl) ``` **The change:** in `dossier_get`, trim the extracted value (leading AND trailing whitespace) with the existing `_dossier_trim` helper before the empty-check and echo. Apply the same to the `agent.json` fallback values for symmetry (jq output is clean today, but the contract should be uniform). **The test:** extend `bin/test-dossier.sh` with a padded fixture (`type: arcade `) asserting three-way agreement: `dossier_validate` passes, `dossier_keys` lists `type`, and `dossier_get` returns exactly `arcade`. Nothing else in scope.

igor added the

Agent

label

2026-08-09 02:05:05 +00:00

igor self-assigned this

2026-08-09 02:43:22 +00:00

igor referenced this issue from a pull request that will close it,

2026-08-09 02:47:20 +00:00

fix: trim dossier_get's extracted values, not just one leading space #478

igor added spent time

2026-08-09 02:47:21 +00:00

3 minutes 45 seconds