review-request to joshtronic fails on APPROVE verdicts #377

Closed
opened 2026-07-11 03:03:16 +00:00 by igor · 0 comments
Collaborator

Diagnosis

During the 21:00 hour the harness logged a warning: review-request to joshtronic failed on two separate APPROVE verdicts (sharktankdb.com #60 and #62). The review verdict itself landed, but the request to route the PR to the human owner (joshtronic) for merge appears to have errored out. The earlier APPROVE on #60 at 21:47:38 requested review cleanly with no warning, so this is inconsistent/intermittent rather than a hard config error — but it recurred within the window and could silently leave approved bot PRs never surfaced to the human reviewer.

Evidence

Jul 10 21:49:52 igor.sherver.org tick.sh[8485]: [agent] warning: review: review-request to joshtronic failed on joshtronic/sharktankdb.com#60 (verdict=APPROVE)
Jul 10 21:49:52 igor.sherver.org tick.sh[8485]: [agent] review: joshtronic/sharktankdb.com#60 requested review from joshtronic (verdict=APPROVE)
Jul 10 21:56:39 igor.sherver.org tick.sh[13682]: [agent] warning: review: review-request to joshtronic failed on joshtronic/sharktankdb.com#62 (verdict=APPROVE)
Jul 10 21:56:39 igor.sherver.org tick.sh[13682]: [agent] review: joshtronic/sharktankdb.com#62 requested review from joshtronic (verdict=APPROVE)

What 'fixed' looks like

The review-request call either succeeds (no warning) or the harness retries/surfaces the underlying API error (e.g. reviewer already requested, permission, or rate limit) instead of emitting the ambiguous warning-then-'requested' pair. Confirm approved PRs actually appear in joshtronic's review queue.


service: agent.service
severity: low
window: 2026-07-10 21:00-22:00 (filed by the hourly logwatch pass)

## Diagnosis During the 21:00 hour the harness logged a `warning: review-request to joshtronic failed` on two separate APPROVE verdicts (sharktankdb.com #60 and #62). The review verdict itself landed, but the request to route the PR to the human owner (joshtronic) for merge appears to have errored out. The earlier APPROVE on #60 at 21:47:38 requested review cleanly with no warning, so this is inconsistent/intermittent rather than a hard config error — but it recurred within the window and could silently leave approved bot PRs never surfaced to the human reviewer. ## Evidence ``` Jul 10 21:49:52 igor.sherver.org tick.sh[8485]: [agent] warning: review: review-request to joshtronic failed on joshtronic/sharktankdb.com#60 (verdict=APPROVE) Jul 10 21:49:52 igor.sherver.org tick.sh[8485]: [agent] review: joshtronic/sharktankdb.com#60 requested review from joshtronic (verdict=APPROVE) Jul 10 21:56:39 igor.sherver.org tick.sh[13682]: [agent] warning: review: review-request to joshtronic failed on joshtronic/sharktankdb.com#62 (verdict=APPROVE) Jul 10 21:56:39 igor.sherver.org tick.sh[13682]: [agent] review: joshtronic/sharktankdb.com#62 requested review from joshtronic (verdict=APPROVE) ``` ## What 'fixed' looks like The review-request call either succeeds (no warning) or the harness retries/surfaces the underlying API error (e.g. reviewer already requested, permission, or rate limit) instead of emitting the ambiguous warning-then-'requested' pair. Confirm approved PRs actually appear in joshtronic's review queue. --- service: agent.service severity: low window: 2026-07-10 21:00-22:00 (filed by the hourly logwatch pass) <!-- agent:logwatch -->
igor added spent time 2026-07-11 03:03:17 +00:00
58 seconds
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Total time spent: 58 seconds
igor
58 seconds
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
joshtronic/igor#377
No description provided.