Gate the CEO reconsider REVISE re-file with the code-check gate (follow-up to #287) #290

New issue

Closed

opened 2026-06-30 03:10:41 +00:00 by igor · 0 comments

igor commented

2026-06-30 03:10:41 +00:00

Collaborator

Follow-up to #287 (the code-check gate). The gate vets proposals against the real code before filing, but only on the paths through _ceo_file_outputs (the weekly digest + the answer-path). The reconsider-path REVISE branch in do_ceo_tick re-files a revised proposal by calling ceo_file_proposal directly, so it bypasses the gate -- a revised proposal could still be already-done.

Scope: in do_ceo_tick (the Path-1b reconsider branch, the REVISE) case), run ceo_codecheck_proposal on the revised title/body before ceo_file_proposal. KEEP -> re-file as today; DROP -> skip the re-file and post a brief reply noting the revision is already covered in the code (the old proposal is already closed in the REVISE flow, so nothing is left in limbo). Mirror the existing gate exactly: fail-open to KEEP on any error, drop-reason logged locally only, never posted.

Acceptance:

The REVISE re-file runs ceo_codecheck_proposal first; KEEP re-files, DROP skips with a one-line reply.
A bin/test-ceo.sh check covers the gated REVISE (KEEP re-files, DROP skips).
bash bin/test-ceo.sh and bash bin/check-sync.sh stay green.

Small and contained -- touches bin/tick.sh (the REVISE case) and bin/test-ceo.sh. Reference: PR #287 and ceo_codecheck_proposal in lib/ceo.sh.

Follow-up to #287 (the code-check gate). The gate vets proposals against the real code before filing, but only on the paths through `_ceo_file_outputs` (the weekly digest + the answer-path). The reconsider-path REVISE branch in `do_ceo_tick` re-files a revised proposal by calling `ceo_file_proposal` directly, so it bypasses the gate -- a revised proposal could still be already-done. **Scope:** in `do_ceo_tick` (the Path-1b reconsider branch, the `REVISE)` case), run `ceo_codecheck_proposal` on the revised title/body before `ceo_file_proposal`. KEEP -> re-file as today; DROP -> skip the re-file and post a brief reply noting the revision is already covered in the code (the old proposal is already closed in the REVISE flow, so nothing is left in limbo). Mirror the existing gate exactly: fail-open to KEEP on any error, drop-reason logged locally only, never posted. **Acceptance:** - The REVISE re-file runs `ceo_codecheck_proposal` first; KEEP re-files, DROP skips with a one-line reply. - A `bin/test-ceo.sh` check covers the gated REVISE (KEEP re-files, DROP skips). - `bash bin/test-ceo.sh` and `bash bin/check-sync.sh` stay green. Small and contained -- touches `bin/tick.sh` (the REVISE case) and `bin/test-ceo.sh`. Reference: PR #287 and `ceo_codecheck_proposal` in `lib/ceo.sh`.

igor self-assigned this

2026-06-30 03:23:24 +00:00

igor referenced this issue from a pull request that will close it,

2026-06-30 03:27:25 +00:00

fix: gate the CEO REVISE re-file with ceo_codecheck_proposal (follow-up to #287) #292

igor added spent time

2026-06-30 03:27:25 +00:00

3 minutes 43 seconds

igor removed their assignment

2026-06-30 03:27:26 +00:00