feedback.sh:269 integer comparison fails with "integer expression expected" #267

New issue

Closed

opened 2026-06-26 17:08:44 +00:00 by igor · 0 comments

igor commented

2026-06-26 17:08:44 +00:00

Collaborator

The feedback-triage module threw a shell error during the 11:45 tick. A [ ... -eq/-gt ... ]-style integer test at lib/feedback.sh:269 received a non-integer (the operand printed across two lines as 0 / 0), indicating an unquoted/multiline variable or a count that came back empty-or-malformed. The tick continued and finished, so it is non-fatal, but it is a genuine code defect in a module that runs every minute, and it appeared after the 11:40 self-update (683bc16 -> 2d73341) so current code is affected.

Jun 26 11:45:37 igor tick.sh[738263]: /home/igor/.local/share/agent/lib/feedback.sh: line 269: [: 0
Jun 26 11:45:37 igor tick.sh[738263]: 0: integer expression expected

None of the recent feedback commits (classify-labels, form-fields-as-hints, exclude-own-tickets, dedup-search) clearly address an integer-comparison bug at this line.

"Fixed" = the operand passed to the [ ... ] test at feedback.sh:269 is quoted and guaranteed to be a single integer (e.g. default empty/whitespace to 0), and a tick exercising the feedback path logs no integer expression expected error.

service: agent.service
severity: medium
window: 2026-06-26 11:00-12:00 (filed by the hourly logwatch pass)

The feedback-triage module threw a shell error during the 11:45 tick. A `[ ... -eq/-gt ... ]`-style integer test at `lib/feedback.sh:269` received a non-integer (the operand printed across two lines as `0` / `0`), indicating an unquoted/multiline variable or a count that came back empty-or-malformed. The tick continued and finished, so it is non-fatal, but it is a genuine code defect in a module that runs every minute, and it appeared *after* the 11:40 self-update (`683bc16 -> 2d73341`) so current code is affected. ``` Jun 26 11:45:37 igor tick.sh[738263]: /home/igor/.local/share/agent/lib/feedback.sh: line 269: [: 0 Jun 26 11:45:37 igor tick.sh[738263]: 0: integer expression expected ``` None of the recent feedback commits (classify-labels, form-fields-as-hints, exclude-own-tickets, dedup-search) clearly address an integer-comparison bug at this line. "Fixed" = the operand passed to the `[ ... ]` test at feedback.sh:269 is quoted and guaranteed to be a single integer (e.g. default empty/whitespace to `0`), and a tick exercising the feedback path logs no `integer expression expected` error. --- service: agent.service severity: medium window: 2026-06-26 11:00-12:00 (filed by the hourly logwatch pass)