forks/node-curl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add some comments

Browse source
This commit is contained in:
jiangfriend@gmail.com 2012-02-14 21:19:06 +08:00
parent 314d43203f
commit d1b7f36918
4 changed files with 17 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.gitignore vendored
View file

@ -1,2 +1,3 @@
raw raw
build build
.lock-wscript

1
.npmignore
View file

@ -1,2 +1,3 @@
raw raw
build build
.lock-wscript

3
examples/quick-start.js
View file

@ -14,7 +14,8 @@ curl(url, options, function(err, res) {
res.close(); res.close();
}); });
curl('www.google.com', {VERBOSE: 1, RAW: 1}, function(err, res) { curl('https://www.google.com', {VERBOSE: 1, RAW: 1}, function(err, res) {
console.info("\x1b[33meffetcive url: " + res.info('EFFECTIVE_URL') + "\x1b[0m");
console.info(res); console.info(res);
res.close(); res.close();
}); });

25
src/node-curl.h
View file

@ -14,8 +14,6 @@
#define NODE_CURL_OPTION(name) NODE_CURL_OPTION_NX(name , CURLOPT_##name) #define NODE_CURL_OPTION(name) NODE_CURL_OPTION_NX(name , CURLOPT_##name)
#define NODE_CURL_EXPORT(name) export_curl_options(t, #name, name, sizeof(name) / sizeof(CurlOption)); #define NODE_CURL_EXPORT(name) export_curl_options(t, #name, name, sizeof(name) / sizeof(CurlOption));
class NodeCurl class NodeCurl
{ {
struct CurlOption { struct CurlOption {
@ -37,6 +35,7 @@ class NodeCurl
: in_curlm(false) : in_curlm(false)
{ {
++count; ++count;
// I know 2*4096 is magical world, but I have no idea the real memory curl will occupied
v8::V8::AdjustAmountOfExternalAllocatedMemory(2*4096); v8::V8::AdjustAmountOfExternalAllocatedMemory(2*4096);
object->SetPointerInInternalField(0, this); object->SetPointerInInternalField(0, this);
handle = v8::Persistent<v8::Object>::New(object); handle = v8::Persistent<v8::Object>::New(object);
@ -329,6 +328,8 @@ class NodeCurl
if (msg->msg == CURLMSG_DONE) if (msg->msg == CURLMSG_DONE)
{ {
NodeCurl * curl = curls[msg->easy_handle]; NodeCurl * curl = curls[msg->easy_handle];
// ensure curl still exists,
// gc will delete the curl if there is no reference.
if (msg->data.result == CURLE_OK) if (msg->data.result == CURLE_OK)
curl->on_end(msg); curl->on_end(msg);
else else
@ -385,20 +386,20 @@ class NodeCurl
t->InstanceTemplate()->SetInternalFieldCount(1); t->InstanceTemplate()->SetInternalFieldCount(1);
// Set prototype methods // Set prototype methods
NODE_SET_PROTOTYPE_METHOD(t, "perform_", perform); NODE_SET_PROTOTYPE_METHOD(t , "perform_" , perform);
NODE_SET_PROTOTYPE_METHOD(t, "setopt_int_", setopt_int); NODE_SET_PROTOTYPE_METHOD(t , "setopt_int_" , setopt_int);
NODE_SET_PROTOTYPE_METHOD(t, "setopt_str_", setopt_str); NODE_SET_PROTOTYPE_METHOD(t , "setopt_str_" , setopt_str);
NODE_SET_PROTOTYPE_METHOD(t, "setopt_slist_", setopt_slist); NODE_SET_PROTOTYPE_METHOD(t , "setopt_slist_" , setopt_slist);
NODE_SET_PROTOTYPE_METHOD(t, "getinfo_int_", getinfo_int); NODE_SET_PROTOTYPE_METHOD(t , "getinfo_int_" , getinfo_int);
NODE_SET_PROTOTYPE_METHOD(t, "getinfo_str_", getinfo_str); NODE_SET_PROTOTYPE_METHOD(t , "getinfo_str_" , getinfo_str);
NODE_SET_PROTOTYPE_METHOD(t, "getinfo_double_", getinfo_double); NODE_SET_PROTOTYPE_METHOD(t , "getinfo_double_" , getinfo_double);
NODE_SET_PROTOTYPE_METHOD(t, "getinfo_slist_", getinfo_slist); NODE_SET_PROTOTYPE_METHOD(t , "getinfo_slist_" , getinfo_slist);
NODE_SET_PROTOTYPE_METHOD(t, "close", close); NODE_SET_PROTOTYPE_METHOD(t, "close", close);
NODE_SET_METHOD(t, "process_", process); NODE_SET_METHOD(t , "process_" , process);
NODE_SET_METHOD(t, "get_count", get_count); NODE_SET_METHOD(t , "get_count" , get_count);
// Set curl constants // Set curl constants
#include "string_options.h" #include "string_options.h"