[eruby] Add GetCommand to erb linter
GetCommand conditionally adds a filter (implemented as inline Ruby code in the command line) to transform some of the problematic Rails-specific eRuby syntax. Specifically, <%= tags are replaced with <%. This does not reduce the effectiveness of the linter, because the transformed code is still evaluated. This solution was suggested by @rgo at https://github.com/w0rp/ale/issues/580#issuecomment-337676607.
This commit is contained in:
parent
e9e29e003c
commit
ea7f68226e
3 changed files with 38 additions and 3 deletions
21
test/command_callback/test_erb_command_callback.vader
Normal file
21
test/command_callback/test_erb_command_callback.vader
Normal file
|
@ -0,0 +1,21 @@
|
|||
Before:
|
||||
runtime ale_linters/eruby/erb.vim
|
||||
call ale#test#SetDirectory('/testplugin/test/command_callback')
|
||||
|
||||
After:
|
||||
call ale#linter#Reset()
|
||||
call ale#test#RestoreDirectory()
|
||||
|
||||
Execute(Executable should not contain any filter code by default):
|
||||
call ale#test#SetFilename('../ruby_fixtures/not_a_rails_app/file.rb')
|
||||
|
||||
AssertEqual
|
||||
\ 'erb -P -x %t | ruby -c',
|
||||
\ ale_linters#eruby#erb#GetCommand(bufnr(''))
|
||||
|
||||
Execute(Executable should filter invalid eRuby when inside a Rails project):
|
||||
call ale#test#SetFilename('../ruby_fixtures/valid_rails_app/app/views/my_great_view.html.erb')
|
||||
|
||||
AssertEqual
|
||||
\ 'ruby -r erb -e ' . ale#Escape('puts ERB.new($stdin.read.gsub(%{<%=},%{<%}), nil, %{-}).src') . ' | ruby -c',
|
||||
\ ale_linters#eruby#erb#GetCommand(bufnr(''))
|
Loading…
Add table
Add a link
Reference in a new issue