Fix #1358, fix #1369 - Lint the package on save for go vet instead

This commit is contained in:
John Eikenberry 2018-02-25 11:39:45 +00:00 committed by w0rp
parent 89f8d3e456
commit 4941bd8d0e
3 changed files with 71 additions and 2 deletions

View file

@ -0,0 +1,16 @@
Before:
runtime ale_linters/go/govet.vim
call ale#test#SetDirectory('/testplugin/test/command_callback')
After:
Restore
call ale#linter#Reset()
call ale#test#RestoreDirectory()
Execute(The default command should be correct):
AssertEqual
\ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
\ . ' go vet .',
\ ale_linters#go#govet#GetCommand(bufnr(''))

View file

@ -0,0 +1,28 @@
Before:
runtime ale_linters/go/govet.vim
After:
call ale#linter#Reset()
Execute(The govet handler should return the correct filenames):
AssertEqual
\ [
\ {
\ 'lnum': 27,
\ 'col': 0,
\ 'text': 'some error',
\ 'type': 'E',
\ 'filename': ale#path#Simplify(expand('%:p:h') . '/test.go'),
\ },
\ {
\ 'lnum': 27,
\ 'col': 5,
\ 'text': 'some error with a column',
\ 'type': 'E',
\ 'filename': ale#path#Simplify(expand('%:p:h') . '/other.go'),
\ },
\ ],
\ ale_linters#go#govet#Handler(bufnr(''), [
\ 'test.go:27: some error',
\ 'other.go:27:5: some error with a column',
\ ])